Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
-----------------------------------------------------------

(Updated Nov. 26, 2015, 8:15 nachm.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Adding Frameworks

Does anyone of you have an idea how to prevent it from registering the copies as applications (see last comments)?


Bugs: ?
    https://bugs.kde.org/show_bug.cgi?id=?


Repository: plasma-workspace


Description
-------

This brings back the KPropertiesDialog to modify an icon's appearance. This has been requested at multiple occasions. This has been adapted from the Plasma 4 icon code.


Diffs
-----

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126149/diff/


Testing
-------

Dropped a file from my home onto the desktop -> dialog from the actual file, allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151126/dde1cb52/attachment.html>