Review Request 125941: Add KCompressionDevice tests to KArchive
David Faure
faure at kde.org
Wed Nov 25 21:51:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88852
-----------------------------------------------------------
autotests/CMakeLists.txt (line 44)
<https://git.reviewboard.kde.org/r/125941/#comment60884>
Oh wow cmake integrates code for this based on libarchive, I didn't know that.
I stand corrected.
- David Faure
On Nov. 25, 2015, 9:19 p.m., Romário Rios wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:19 p.m.)
>
>
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply did not work, so I'm adding some tests to confirm that
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 1b2e819
> autotests/kcompressiondevicetest.h PRE-CREATION
> autotests/kcompressiondevicetest.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
>
>
> Testing
> -------
>
> The tests run and show that KCompressionDevice works properly with QBuffer when used with KTar
>
>
> Thanks,
>
> Romário Rios
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151125/080f1dec/attachment.html>
More information about the Kde-frameworks-devel
mailing list