Review Request 125941: Add KCompressionDevice tests to KArchive

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88850
-----------------------------------------------------------



autotests/CMakeLists.txt (line 44)
<https://git.reviewboard.kde.org/r/125941/#comment60880>

    sorry I just realized something else: these calls to "tar" will break on Windows.
    
    I would suggest to either
    1) add small archives to git, or
    2) create those from code using KArchive
    
    Of course there's also easy option 3: find_program(TAR tar)
    if (Qt5Network_FOUND AND TAR)
    ...
    and then using ${TAR} instead of tar, to be consistent.



autotests/CMakeLists.txt (line 53)
<https://git.reviewboard.kde.org/r/125941/#comment60881>

    this one should be in
    if (LIBLZMA_FOUND)



autotests/kcompressiondevicetest.cpp (line 135)
<https://git.reviewboard.kde.org/r/125941/#comment60882>

    #if HAVE_XZ_SUPPORT
            ...
        #else
            QSKIP("...")
        #endif


- David Faure


On Nov. 25, 2015, 9:19 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 9:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> -------
> 
> The tests run and show that KCompressionDevice works properly with QBuffer when used with KTar
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151125/fdba69e0/attachment.html>