Review Request 126164: Request proper dbus name for kioexec

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126164/#review88785
-----------------------------------------------------------

Ship it!


"in kde" -> you meant in kde4 (kde-runtime4 more precisely).

This is a valid fix. We could also look at making kinit not require dbus registration from kioexec; usually kinit gets this information from the desktop file of the app, but for kioexec there's no desktop file, so it must be hardcoded somewhere.

- David Faure


On Nov. 25, 2015, 8:20 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126164/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 8:20 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 353037
>     https://bugs.kde.org/show_bug.cgi?id=353037
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Dolphin make a synchronous calls to klauncher and klauncher asks kdeinit to start kioexec. The call is only replied when kioexec's dbus name appear on the dbus.
> 
> Possibly in kde it uses kapplication and kdbusservice name is not added when porting to qt5/kf5.
> 
> 
> Diffs
> -----
> 
>   src/kioexec/CMakeLists.txt 91284a3 
>   src/kioexec/main.cpp 68ed374 
> 
> Diff: https://git.reviewboard.kde.org/r/126164/diff/
> 
> 
> Testing
> -------
> 
> Dolphin now does not freeze in this case.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151125/c32f41df/attachment.html>