Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metadata

[Nick Shaforostoff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126140/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 11:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Juan Palacios, Pino Toscano, and Vishesh Handa.


Changes
-------

Submitted with commit 4655943a49acfa181d31a00c5aef1bf10dcba2bf by Nick Shaforostoff to branch master.


Repository: kfilemetadata


Description
-------

also this patch marks 'audio/mp4' mimetype as supported by taglib for reading .m4a files (AAC or ALAC)


Diffs
-----

  src/extractors/taglibextractor.cpp 3bf33cd 

Diff: https://git.reviewboard.kde.org/r/126140/diff/


Testing
-------

tested with Spanish accents (e.g. José, Cátulo) in the tags.

also i did test this toCWString-based conversion on windows and it worked fine. should work on osx as well


Thanks,

Nick Shaforostoff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151124/83c38fae/attachment.html>