Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

Boudhayan Gupta bgupta at kde.org
Tue Nov 24 11:53:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 11:53 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Edmundson.


Changes
-------

Submitted with commit a8c177911dea1e099bfb499f199ee7039c756cde by Boudhayan Gupta to branch master.


Repository: khotkeys


Description
-------

After moving KSnapshot to Extragear I've modified it to install its own khotkeys file (which it does correctly). Spectacle already installs its own KHotkeys file, so there's no reason anymore for KHotkeys to include its own PrintScreen hotkey file.

I'll push out a special release of KSnapshot for distributions to use once the Plasma 5.5 version of KHotkeys is pushed out, so printscreen functionality won't be broken on the desktop (assuming, that is, distros push out the updates together).


Diffs
-----

  data/CMakeLists.txt f3bcb57 
  data/printscreen.khotkeys e583311 

Diff: https://git.reviewboard.kde.org/r/126091/diff/


Testing
-------

Doesn't install the printscreen.khotkeys file anymore


Thanks,

Boudhayan Gupta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151124/a0c8c71e/attachment.html>


More information about the Kde-frameworks-devel mailing list