Review Request 125640: Remove special handling when service is already registered

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125640/
-----------------------------------------------------------

(Updated Nov. 23, 2015, 8:23 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit ef7e90d73971dce9f3bceef2a66f4c07689d4e5f by Martin Klapetek to branch master.


Repository: kwallet


Description
-------

As pointed out in https://git.reviewboard.kde.org/r/125483/ the special handling is useless here. If the service is registered, it will call Activate and KDBusService will just exit, even with the NoExitOnFailure flag; it would never reach the "if (!dbusUniqueInstance.isRegistered()) {".

Furthermore, without the NoExitOnFailure flag, it would exit right from KDBusService, rendering this whole if-block kinda useless.


Diffs
-----

  src/runtime/kwalletd/main.cpp fbab58d 

Diff: https://git.reviewboard.kde.org/r/125640/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151123/9ae04faa/attachment.html>