Review Request 126087: Move the i18n context from KDeclarative

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/#review88717
-----------------------------------------------------------



src/klocalizedcontext.cpp (line 76)
<https://git.reviewboard.kde.org/r/126087/#comment60832>

    Style wise, shouldn't this conditional also use braces?



src/klocalizedcontext.cpp (line 79)
<https://git.reviewboard.kde.org/r/126087/#comment60831>

    If this happens, all subsequent substitutions will use placeholders shifted back by one, so the message will be messed up more than necessary. Better substitute something, e.g. "???".


- Chusslove Illich


On Нов. 23, 2015, 12:54 по п., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126087/
> -----------------------------------------------------------
> 
> (Updated Нов. 23, 2015, 12:54 по п.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Marco Martin.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n.
> This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1cf0f7a 
>   autotests/ki18ndeclarativetest.cpp PRE-CREATION 
>   autotests/test.qml PRE-CREATION 
>   docs/programmers-guide.md 13a5f9d 
>   src/CMakeLists.txt 818595e 
>   src/klocalizedcontext.h PRE-CREATION 
>   src/klocalizedcontext.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126087/diff/
> 
> 
> Testing
> -------
> 
> Ported KDeclarative, everything still seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151123/b63f397a/attachment.html>