Review Request 126087: Move the i18n context from KDeclarative

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/#review88697
-----------------------------------------------------------

Ship it!



autotests/ki18ndeclarativetest.cpp (line 31)
<https://git.reviewboard.kde.org/r/126087/#comment60820>

    de-indent?



src/klocalizedcontext.h (line 58)
<https://git.reviewboard.kde.org/r/126087/#comment60821>

    explicit and Q_NULLPTR or nullptr



src/klocalizedcontext.h (line 59)
<https://git.reviewboard.kde.org/r/126087/#comment60822>

    virtual



src/klocalizedcontext.h (line 132)
<https://git.reviewboard.kde.org/r/126087/#comment60823>

    are we sure we'll never add anything else? i.e. is pimpling a safer choice?


- Milian Wolff


On Nov. 20, 2015, 2:03 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126087/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 2:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Marco Martin.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n.
> This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1cf0f7a 
>   autotests/ki18ndeclarativetest.cpp PRE-CREATION 
>   autotests/test.qml PRE-CREATION 
>   docs/programmers-guide.md 13a5f9d 
>   src/CMakeLists.txt 818595e 
>   src/klocalizedcontext.h PRE-CREATION 
>   src/klocalizedcontext.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126087/diff/
> 
> 
> Testing
> -------
> 
> Ported KDeclarative, everything still seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151122/1616af51/attachment.html>