Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metadata

Nick Shaforostoff shafff at ukr.net
Sun Nov 22 18:51:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126140/
-----------------------------------------------------------

Review request for KDE Frameworks and Vishesh Handa.


Repository: kfilemetadata


Description
-------

also this patch marks 'audio/mp4' mimetype as supported by taglib for reading .m4a files (AAC or ALAC)


Diffs
-----

  src/extractors/taglibextractor.cpp 3bf33cd 

Diff: https://git.reviewboard.kde.org/r/126140/diff/


Testing
-------

tested with Spanish accents (e.g. José, Cátulo) in the tags.

also i did test this toCWString-based conversion on windows and it worked fine. should work on osx as well


Thanks,

Nick Shaforostoff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151122/9a22e0b1/attachment.html>


More information about the Kde-frameworks-devel mailing list