Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons
Heiko Becker
heirecka at exherbo.org
Sun Nov 22 13:57:16 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126056/
-----------------------------------------------------------
(Updated Nov. 22, 2015, 1:57 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Uri Herrera.
Changes
-------
Submitted with commit 5a501dd330b6a61cf6eb909946e5295115fe7693 by Heiko Becker to branch master.
Repository: breeze-icons
Description
-------
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
Also clean up unecessary cmake code. "cmake_minimum_required(VERSION 2.8)"
was already set to a higher value in the root CMakeLists.txt, same for
"set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")".
Furthermore I couldn't find any '*.sh' files in the repo.
REVIEW: 126056
Diffs
-----
icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd
icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0
Diff: https://git.reviewboard.kde.org/r/126056/diff/
Testing
-------
Icons get installed into the desired location.
Thanks,
Heiko Becker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151122/0f70a45b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list