Review Request 126085: Fix filename suggestion changing to something random when changing save-as mimetype.

David Faure faure at kde.org
Sat Nov 21 21:05:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126085/#review88683
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Nov. 16, 2015, 12:05 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126085/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 12:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When updating save-as mimetype update suggested default name before updating show list
> 
> Otherwise KDirOperator will signal that we have gone from having an
> existing item selected to having no item selected and will then select
> the first file that matches the new mime filter criteria.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilewidget.cpp 918a49941ce1610d1b2bb7764b07fc4f81238313 
> 
> Diff: https://git.reviewboard.kde.org/r/126085/diff/
> 
> 
> Testing
> -------
> 
> Assume directory with file a.png
> 
> open b.jpg in gwenview
> -> save as
> select "png" as the type, after patch filename still says b.png (as opposed to jump to a.png)
> 
> ---
> 
> Tested above in a directory where b.png already existed
> 
> ---
> 
> Tested selecting another file before changing file type
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151121/fcc91402/attachment.html>


More information about the Kde-frameworks-devel mailing list