Review Request 126113: make event filters static to decrease installed filters on qApp

Aleix Pol Gonzalez aleixpol at kde.org
Fri Nov 20 13:31:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126113/#review88649
-----------------------------------------------------------



src/plasma/svg.cpp (line 581)
<https://git.reviewboard.kde.org/r/126113/#comment60769>

    It could be useful to use qGuiApp here, so that software that doesn't use QApplication can use it as well.


- Aleix Pol Gonzalez


On Nov. 20, 2015, 2:27 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126113/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 2:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 351923
>     http://bugs.kde.org/show_bug.cgi?id=351923
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> since seems there are so many event filters installed on the QApplication installed that may give performance issues, try to use separate, singleton watchers for them to decrease the amount of eventfilters called
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/units.h fa2256e 
>   src/declarativeimports/core/units.cpp 4e2adae 
>   src/plasma/private/svg_p.h 597465e 
>   src/plasma/private/theme_p.h 5b8f71c 
>   src/plasma/private/theme_p.cpp f346343 
>   src/plasma/svg.cpp bcceaf7 
> 
> Diff: https://git.reviewboard.kde.org/r/126113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151120/83426a55/attachment.html>


More information about the Kde-frameworks-devel mailing list