Review Request 126087: Move the i18n context from KDeclarative
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Nov 19 16:00:11 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/
-----------------------------------------------------------
(Updated Nov. 19, 2015, 5 p.m.)
Review request for KDE Frameworks, Chusslove Illich and Marco Martin.
Changes
-------
Added a tiny test.
I'd say exporting this class should be ok. Introducing a module that can be imported from within QML would be nice as well. I can work on it next if you like.
Repository: ki18n
Description
-------
The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n.
This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts.
Diffs (updated)
-----
autotests/CMakeLists.txt 1cf0f7a
autotests/ki18ndeclarativetest.cpp PRE-CREATION
autotests/test.qml PRE-CREATION
docs/programmers-guide.md 13a5f9d
src/CMakeLists.txt 818595e
src/klocalizedcontext.h PRE-CREATION
src/klocalizedcontext.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126087/diff/
Testing
-------
Ported KDeclarative, everything still seems to work.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151119/07b97005/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list