Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

Kevin Funk kfunk at kde.org
Thu Nov 19 14:44:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126117/#review88602
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Nov. 19, 2015, 1:33 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126117/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> We need to disconnect from a previous source model if present, not the new one, and we need to be prepared for the new source model to be 0.
> 
> 
> Diffs
> -----
> 
>   src/krecursivefilterproxymodel.cpp 8219ef4 
> 
> Diff: https://git.reviewboard.kde.org/r/126117/diff/
> 
> 
> Testing
> -------
> 
> Fixes 0-sender runtime warnings in GammaRay, which makes use of resetting the source model.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151119/a31c851f/attachment.html>


More information about the Kde-frameworks-devel mailing list