Review Request 126110: Clean up and armour Baloo::Database::open()
Boudhayan Gupta
bgupta at kde.org
Thu Nov 19 11:00:52 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126110/
-----------------------------------------------------------
Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
Repository: baloo
Description
-------
* Add checks for failures
* Add manual checks after Q_ASSERT* (they're not compiled in Release mode)
* Clean up m_env after failure, not just set it to 0
Diffs
-----
src/engine/database.cpp e39eb86
Diff: https://git.reviewboard.kde.org/r/126110/diff/
Testing
-------
Builds, runs, does not crash.
make test succeeds at 100%
Thanks,
Boudhayan Gupta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151119/596eb6fb/attachment.html>
More information about the Kde-frameworks-devel
mailing list