Review Request 126087: Move the i18n context from KDeclarative

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/#review88431
-----------------------------------------------------------



src/klocalizedcontext.h (line 63)
<https://git.reviewboard.kde.org/r/126087/#comment60606>

    please break these overly long lines



src/klocalizedcontext.cpp (line 51)
<https://git.reviewboard.kde.org/r/126087/#comment60607>

    again, please break these long lines



src/klocalizedcontext.cpp (line 53)
<https://git.reviewboard.kde.org/r/126087/#comment60609>

    isNull or isEmpty? Don't we usually want to check against isEmpty and never against isNull? Isn't the latter even quasi-deprecated as it's internal state is somewhat undocumented and one must not depend on it? I think I remember something like that from the qt devel mailing list... Should ask Thiago again maybe?



src/klocalizedcontext.cpp (line 113)
<https://git.reviewboard.kde.org/r/126087/#comment60608>

    I'd like to see this common code shared


- Milian Wolff


On Nov. 16, 2015, 12:57 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126087/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 12:57 p.m.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Marco Martin.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n.
> This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 818595e 
>   src/klocalizedcontext.h PRE-CREATION 
>   src/klocalizedcontext.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126087/diff/
> 
> 
> Testing
> -------
> 
> Ported KDeclarative, everything still seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151116/e90ce74b/attachment-0001.html>