Review Request 126057: Use KDE_INSTALL_FULL_ICONDIR to install the icons

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/#review88340
-----------------------------------------------------------

Ship it!


KDEInstallDirs will take care of keeping compatibility for what you can pass on the cmake command line. Although I'd also get rid of the distinction between WIN32 and not WIN32 - it seems pretty pointless to me.

- Alex Merry


On Nov. 13, 2015, 6:04 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126057/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 6:04 p.m.)
> 
> 
> Review request for KDE Frameworks and andreas kainz.
> 
> 
> Repository: oxygen-icons5
> 
> 
> Description
> -------
> 
> It was previously hard-coded to prefix/share which is not helpful on a
> multiarch layout, where the prefix might be something like /usr/$\{arch\}
> but arch independent files should still go into /usr/share.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8596219 
> 
> Diff: https://git.reviewboard.kde.org/r/126057/diff/
> 
> 
> Testing
> -------
> 
> Icons get installed into the desired location.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151113/51f2f9f4/attachment.html>