Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

[David Edmundson]

> On Nov. 13, 2015, 6:59 a.m., Martin Gräßlin wrote:
> > shouldn't we just delete the code? Qt nowadays does SNI and if not we have the xembed-sni-proxy. Thoughts on that? Maybe bound to the Qt version which introduced the SNI support?

Could do.
I've not tried Qt's version of SNI myself.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126047/#review88310
-----------------------------------------------------------


On Nov. 12, 2015, 7:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126047/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> If any app is written using QSystemTrayIcon they'll have to provide
> their own quit action in order to work on other platforms. We don't want to add our own on top otherwise we get two quit actions.
> 
> BUG: 354991
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 7536697d59ed2b2f11aa10180e87d003b5579a16 
> 
> Diff: https://git.reviewboard.kde.org/r/126047/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151113/89bb982c/attachment.html>