Review Request 125936: Update KProtocolManager after configuration change.

[Andreas Cord-Landwehr]

> On Nov. 6, 2015, 8:02 a.m., David Faure wrote:
> > src/kcms/kio/cache.cpp, line 91
> > <https://git.reviewboard.kde.org/r/125936/diff/1/?file=414667#file414667line91>
> >
> >     Isn't this done by the call to updateRunningIOSlaves just below, which sends the DBus signal "reparseSlaveConfiguration" to all processes with a KIO scheduler, which, in SchedulerPrivate::slotReparseSlaveConfiguration, calls KProtocolManager::reparseConfiguration?
> >     
> >     Please check why this doesn't happen in your testcase.
> >     I can think of a few possibilities:
> >     - there's no KIO scheduler in this process
> >     - you need this reparsed before going back to the event loop (but from your description it doesn't seem so)
> >     - there's a bug in the emitting or the handling of that dbus signal (which is why I'm asking, if there is, we might as well find it and fix it).
> 
> Andreas Cord-Landwehr wrote:
>     Thanks for the infos. Regarding the even-loop I agree that this cannot be the problem.
>     I just tested for the KIO scheduler. With the open KCM dialog I get:
>     
>     cordlandwehr at weatherwax:~$ qdbus "org.kde.KIO.Scheduler"
>     Service 'org.kde.KIO.Scheduler' does not exist.
>     
>     So, I would deduce that no scheduler exists, or do I miss anything?
> 
> David Faure wrote:
>     You're confusing dbus service names and dbus interface names.
>     You need to call `qdbus <name under which the KCM registered to dbus> /KIO/Scheduler`
>     
>     The KIO scheduler is a class in each process that uses KIO, it's not a desktop-wide daemon.

I see. So, the next try:

qdbus org.kde.internal.KSettingsWidget_kcm_kio /KIO/Scheduler
Error: org.freedesktop.DBus.Error.UnknownObject
No such object path '/KIO/Scheduler'

Although I could not find a specific setting of the KCM servicename, I checked that this is the right servicename by checking that it is only registered when the KCM is open.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125936/#review88081
-----------------------------------------------------------


On Nov. 4, 2015, 6:28 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125936/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 6:28 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fixes missing update of Settings->Cache KCM that happens if opening
> KCM, changing values (e.g., "No Cache"), closing Cache KCM, opening Cache
> KCM again.
> 
> Reason is that storing and loading of UI values is performed
> asymmetrically in two different KSharedConfig objects. Now force second
> KSharedData to sync once settings are saved.
> 
> 
> Diffs
> -----
> 
>   src/kcms/kio/cache.cpp 8f2f4e8 
> 
> Diff: https://git.reviewboard.kde.org/r/125936/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151111/356ee113/attachment.html>