Review Request 125976: add an update() method

Marco Martin notmart at gmail.com
Mon Nov 9 13:18:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
-----------------------------------------------------------

(Updated Nov. 9, 2015, 1:18 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Changes
-------

most issues adressed, will still give a try in having meaningful error codes for the jobs as well


Repository: kpackage


Description
-------

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-----

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp cccc567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
-------

covered by autotests


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151109/16cad769/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list