Review Request 126004: add symlink verification tech

Harald Sitter sitter at kde.org
Mon Nov 9 11:21:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126004/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: breeze-icons


Description
-------

to ensure greatest possible compatibility icon names are often symlinked
to other names. unfortunately symlinks can easily break without anyone
noticing. the symlinktest is supposed to prevent this by iterating the
entire project tree's symlinks and checking if they are actually pointing
to something.
additionally symlinks must not point to out-of-tree files. even if valid.


Diffs
-----

  COPYING.LIB PRE-CREATION 
  autotests/CMakeLists.txt PRE-CREATION 
  CMakeLists.txt 130b3346a6dc6dd86e65cc68bac6ccca19edf772 
  autotests/symlinktest.cpp PRE-CREATION 
  autotests/testdata.h.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126004/diff/


Testing
-------

ctest with both conditions true and false (master actually doesn't pass right now :()


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151109/bbfedfd7/attachment.html>


More information about the Kde-frameworks-devel mailing list