Review Request 126002: Fix KArchive for behavior change in Qt 5.6
David Faure
faure at kde.org
Mon Nov 9 07:54:51 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126002/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 7:54 a.m.)
Review request for KDE Frameworks.
Changes
-------
oops, fix title
Summary (updated)
-----------------
Fix KArchive for behavior change in Qt 5.6
Repository: karchive
Description (updated)
-------
Fix KArchive for behavior change in Qt 5.6
Embedded NULs are now preserved when converting from QByteArray to QString.
+ remove unused var (separate commit)
Diffs
-----
autotests/karchivetest.cpp d9662f5faadf9f08f71a386c0f9ecc8ef89af23a
src/karchive.cpp e0a1eb2245767f9d605c44a6da481d290c2b15a5
src/ktar.cpp 824395e72e73b23f974614d5eff1fa58c7729dc0
Diff: https://git.reviewboard.kde.org/r/126002/diff/
Testing
-------
karchivetest passes again, with Qt 5.6 from git.
I complained about the behavior change on https://codereview.qt-project.org/106473
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151109/f6da1893/attachment.html>
More information about the Kde-frameworks-devel
mailing list