Review Request 125885: Support socks5 proxy in KTcpSocket

[Xuetian Weng]

> On Nov. 2, 2015, 8:08 a.m., David Faure wrote:
> > Ah I see, forget what I said about HTTP proxy.
> > 
> > About the missing argument, it would indeed be useful for this code:
> > http://lxr.kde.org/source/extragear/network/konversation/src/irc/server.cpp
> > Add a separate method, for BC reasons.

After you mentioned it, I actually test the http proxy (proxy server I used is polipo) and pure tcp, and it does support tcp connection over http proxy.

I'd like to be more careful for other users of ktcpsocket in ioslaves.

KTcpSocket does not know the protocol that this TcpSocket will use. But http ioslave uses setApplicationProxy to set the proxy. Use connectionHost with policy = AutoProxy may make http uses socks instead http proxy by default. Same applies to ftp ioslave and maybe others ioslave use TCPSlaveBase.

I wonder if there should also be some protocol hint argument of connectHost, or http and ftp ioslave should use policy = ManualProxy.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125885/#review87847
-----------------------------------------------------------


On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125885/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 342402
>     https://bugs.kde.org/show_bug.cgi?id=342402
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Automatically set socks5 proxy in KTcpSocket.
> 
> 
> Diffs
> -----
> 
>   src/core/ktcpsocket.h ffa3f0b 
>   src/core/ktcpsocket.cpp fde35a7 
> 
> Diff: https://git.reviewboard.kde.org/r/125885/diff/
> 
> 
> Testing
> -------
> 
> Test with akonadi imap agent, connect through socks5 proxy.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151108/ccf8b6dd/attachment.html>