Review Request 125904: Save proxy url with correct scheme.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125904/#review88076
-----------------------------------------------------------

Ship it!


If it worked in KDE SC 4, then the fix is probably much simpler than this (URLs without scheme usually sound like KUrl->QUrl porting bugs).
But otherwise, this fix looks good.

- David Faure


On Nov. 3, 2015, 3:48 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125904/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 3:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Currently, if user type a ip address/domain name in socks 5 proxy field, the saved proxy url in configuration file will start with http:// instead of socks:// . Same applies to ftp proxy.
> 
> The reason is that KUrlFilter append http scheme to url without scheme. This patch uses setDefaultUrlScheme to make sure the correct scheme is used.
> 
> Also make necessary change to make sure that loading url configuration will hide url scheme correctly.
> 
> 
> Diffs
> -----
> 
>   src/kcms/kio/kproxydlg.cpp c8fd0cd 
> 
> Diff: https://git.reviewboard.kde.org/r/125904/diff/
> 
> 
> Testing
> -------
> 
> Save socks proxy and ftp proxy will result in "ftp://" and "socks://".
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151106/e022df6f/attachment.html>