Review Request 125974: Make KTar KCompressionDevice-friendly

Romário Rios luizromario at gmail.com
Fri Nov 6 02:52:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125974/
-----------------------------------------------------------

Review request for KDE Frameworks and Aleix Pol Gonzalez.


Repository: karchive


Description
-------

Up until now, since at least 5.12, decompressing some data coming directly from a QIODevice by using KCompressionDevice because this is a sequential device, and KTar and KArchive used to use QIODevice::seek and pos and some places, which made the decompression fail. This patch makes KTar sequential-friendly by replacing the calls to seek and pos with read and a simple counter, respectively.


Diffs
-----

  src/karchive.cpp 0ece37c 
  src/ktar.cpp 824395e 

Diff: https://git.reviewboard.kde.org/r/125974/diff/


Testing
-------

Makes the tests from review #125941 pass


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151106/fb137418/attachment.html>


More information about the Kde-frameworks-devel mailing list