Review Request 125971: k7zip: fix memleaks, lower memory usage
Nick Shaforostoff
shafff at ukr.net
Thu Nov 5 23:55:33 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125971/
-----------------------------------------------------------
Review request for KDE Frameworks and Laurent Montel.
Repository: karchive
Description
-------
i couldn't find the place where the pointers contained in the member arrays are deleted so i have added their releasing. for this i have used qDeleteAll (you can search for qDeleteAll in the diff)
also i have reordered members of FileInfo to reduce its 'sizeof'
also using qvector for storing pointers is as fast as using qlist (or even faster) and needs less memory
also i have switched qvector acces from operator[] to .at() because it is const (doesn't call detach() method internally)
also i have disabled the code that was filling 'method' string because it was not used anywhere after
Diffs
-----
src/k7zip.cpp 321620a
Diff: https://git.reviewboard.kde.org/r/125971/diff/
Testing
-------
compiles fine
Thanks,
Nick Shaforostoff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151105/38fa0a71/attachment.html>
More information about the Kde-frameworks-devel
mailing list