Review Request 125960: Fix build of some projects using ecm_create_qm_loader()

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125960/#review88069
-----------------------------------------------------------


I'm confused about what you're trying to acheive with this. What you've actually done, as far as I can tell, is *stop* the files being set in the parent scope. That will make the project build, yes, but it will make ecm_create_qm_loader() essentially useless, because the file we generated won't be added to the target, and so won't be built.

Did you try running the unit tests? Because I'd be very surprised if they passed.

I suspect the issue analitza is having is similar to what I fixed in http://commits.kde.org/kconfig/19513e1910f19375a4c17a61f048c7f8c2f9e840 - using the file generation macro in a different CMakeLists.txt to the target the files are added to. Although I haven't looked at analitza's source code to be sure.

- Alex Merry


On Nov. 5, 2015, 2:36 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125960/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:36 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Makes sure the variable is properly initialized.
> 
> 
> Diffs
> -----
> 
>   modules/ECMPoQmTools.cmake 22258dc 
> 
> Diff: https://git.reviewboard.kde.org/r/125960/diff/
> 
> 
> Testing
> -------
> 
> This error won't happen anymore:
> https://build.kde.org/job/analitza%20master%20kf5-qt5/12/PLATFORM=Linux,compiler=gcc/console
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151105/ca2e734a/attachment.html>