Review Request 125941: Add KCompressionDevice tests to KArchive

[Romário Rios]

> On Nov. 4, 2015, 2:11 a.m., Aleix Pol Gonzalez wrote:
> > autotests/kcompressiondevicetest.cpp, line 29
> > <https://git.reviewboard.kde.org/r/125941/diff/1/?file=414723#file414723line29>
> >
> >     Can't KArchive do that already?

I don't believe it can. It can do the opposite -- CompressionType by filename or mimetype --, but not this.


- Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review87980
-----------------------------------------------------------


On Nov. 4, 2015, 9:34 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 9:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> -------
> 
> The tests run and show that KCompressionDevice isn't working as expected
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151104/8b54eeaf/attachment.html>