Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

Michael Pyne mpyne at kde.org
Wed Nov 4 00:06:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125938/#review87977
-----------------------------------------------------------

Ship it!


Looks good to me.

- Michael Pyne


On Nov. 3, 2015, 8:53 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125938/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Need to use POD types.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kpixmapcache.cpp c16384d 
> 
> Diff: https://git.reviewboard.kde.org/r/125938/diff/
> 
> 
> Testing
> -------
> 
> kigo doesn't crash on startup anymore.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151104/2759e60e/attachment.html>


More information about the Kde-frameworks-devel mailing list