Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

Heiko Becker heirecka at exherbo.org
Tue Nov 3 17:48:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125852/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 5:48 nachm.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Ivan Čukić.


Bugs: 354521
    http://bugs.kde.org/show_bug.cgi?id=354521


Repository: kactivities


Description
-------

This "fixes" the build with said cmake param when boost isn't available.
The boost dependency was introduced with 9274281f68b9fc387848a4b49b36934b6b216b3c.

BUG:354521


Diffs
-----

  src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 

Diff: https://git.reviewboard.kde.org/r/125852/diff/


Testing
-------

Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE.

Not sure if this is an acceptable way to fix the issue, or if the option should be made to work without boost (or the option should possibly get removed).


Thanks,

Heiko Becker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151103/77027506/attachment.html>


More information about the Kde-frameworks-devel mailing list