Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

Ivan Čukić ivan.cukic at kde.org
Tue Nov 3 17:21:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125852/#review87947
-----------------------------------------------------------


The current master (the library) should build without boost now.

- Ivan Čukić


On Oct. 28, 2015, 9:48 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125852/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 9:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Čukić.
> 
> 
> Bugs: 354521
>     http://bugs.kde.org/show_bug.cgi?id=354521
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> This "fixes" the build with said cmake param when boost isn't available.
> The boost dependency was introduced with 9274281f68b9fc387848a4b49b36934b6b216b3c.
> 
> BUG:354521
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 
> 
> Diff: https://git.reviewboard.kde.org/r/125852/diff/
> 
> 
> Testing
> -------
> 
> Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE.
> 
> Not sure if this is an acceptable way to fix the issue, or if the option should be made to work without boost (or the option should possibly get removed).
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151103/fd899673/attachment.html>


More information about the Kde-frameworks-devel mailing list