Review Request 125905: Make kactivitymanagerd a QApplication

Martin Gräßlin mgraesslin at kde.org
Mon Nov 2 09:30:42 UTC 2015



> On Nov. 1, 2015, 12:49 p.m., Ivan Čukić wrote:
> > So, we went a full circle back to QApplication :)
> > 
> > What assert are you hitting on unity?
> 
> Albert Astals Cid wrote:
>     KWindowSystem uses QApplication::desktopWidget which you can't if you're not a QApplication

> What assert are you hitting on unity?

The reason for this is that Compiz in opposite to KWin does virtual desktops through viewports. The code paths with the desktopWidget are the fallback code paths for viewport handling.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125905/#review87792
-----------------------------------------------------------


On Nov. 1, 2015, 2:33 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125905/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 2:33 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> KWindowSystem is QWidget based so needs QApplication or asserts in some situations (when run on unity7 for example)
> 
> 
> Diffs
> -----
> 
>   src/service/Application.h 387d4d7 
>   src/service/Application.cpp ec74daa 
> 
> Diff: https://git.reviewboard.kde.org/r/125905/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151102/07193501/attachment.html>


More information about the Kde-frameworks-devel mailing list