Review Request 125915: Drop runtime dependency on QApplication

Aleix Pol Gonzalez aleixpol at kde.org
Sun Nov 1 22:55:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125915/#review87827
-----------------------------------------------------------



src/platforms/xcb/kwindowsystem.cpp (line 585)
<https://git.reviewboard.kde.org/r/125915/#comment60267>

    Just compute once and use the same QRect instance all long this function.


- Aleix Pol Gonzalez


On Nov. 1, 2015, 11:34 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125915/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 11:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> QDesktopWidget was used which is broken for applications using
> QGuiApplication.
> 
> QDesktopWidget is now just a thin wrapper over QScreen so we can use that directly.
> 
> QApplication::activeWindow is ported to QGuiApplication::topLevelWindows
> and then itterating to see if one is active.
> 
> 
> Diffs
> -----
> 
>   src/platforms/xcb/kwindowsystem.cpp 9d287043c24894ca3c29c439c7939b139da055e8 
> 
> Diff: https://git.reviewboard.kde.org/r/125915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151101/f055760a/attachment.html>


More information about the Kde-frameworks-devel mailing list