Proposal: move KWalletManager inside KWallet framework

[Valentin Rusu]

* Stefan Bruens <stefan.bruens at rwth-aachen.de> [2015-05-29 03:48:46 +0200]:

> > > Details:
> > > 
> > > 1. kwalletd5 checks the migration status. In case it already has run, it
> > > immediately signals completion, otherwise the wizard is run and completion
> > > is signaled afterwards.
> > > 
> > > 2. Upon migration completion, kwalletd5 queues a service registration
> > > request for "org.kde.kwalletd". This either immmediately succeeds, or we
> > > get a QDBusConnectionInterface::ServiceQueued reply.
> > > 
> > > 3. In case the request has been queued, org.kde.KApplication::quit() is
> > > called via dbus. kwalletd5 becomes the new org.kde.kwalletd service owner
> > What about org.kde.kwalletd5 name? That's required for the KF5 KWallet
> > API class.
> 
> The kwalletd5 service is registered as well, this part is completely 
> unchanged.

That's very good news!

> > > The patch is a little bit ugly at the moment, but you can find it here:
> > > 
> > > https://build.opensuse.org/package/show/home:StefanBruens:branches:KDE:Fra
> > > meworks5/kwallet
> > Yeah, looking into this patch, I can confirm that the KF5 applications
> > would have problems finding the wallet once the service name changed.
> 
> The service name does not change, kwalletd5 registers both org.kde.kwalletd 
> and org.kde.kwalletd5.
> 
> I have checked with nm-applet5 (org.kde.kwalletd5) and akonadi 
> (org.kde.kwalletd), both can retrieve their secrets from kwalletd5.
> 

Ok, I should also test this. Do you have a KDE commiter account? Can you
push a branch with your patched code, in the KWallet framework, please?


-- 
Valentin Rusu
IRC: valir