Review Request 123778: Fix crash when DBus call ends with error

[David Rosca]

> On May 27, 2015, 2:55 p.m., Ivan Čukić wrote:
> > Sorry for missing this one. You should ping me on IRC when you submit a patch and I miss it.
> > 
> > Thanks for the patch, though, kactivities now include code similar to this.

Ok, will do next time.
Yep, you already fixed this crash, so I discarded the rr :-)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123778/#review80899
-----------------------------------------------------------


On May 27, 2015, 2:43 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123778/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 2:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> If the DBus call ends with error, reportResult is not called in DBusCallFutureInterface and calling QFuture::result() without actually setting the result leads to crash.
> 
> In case of error, continuation callback is not called (maybe it would be good to somehow indicate the error?).
> 
> 
> Diffs
> -----
> 
>   src/utils/dbusfuture_p.h 336235c 
> 
> Diff: https://git.reviewboard.kde.org/r/123778/diff/
> 
> 
> Testing
> -------
> 
> No longer crashes
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150527/9afb2b50/attachment.html>