Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

[David Edmundson]

> On May 25, 2015, 6:09 p.m., Eike Hein wrote:
> > Preserving the owner of an existing file is a good idea, but won't help if there isn't one yet ...?
> 
> David Edmundson wrote:
>     I put in the other two fixes too, the next app would wipe that file and rebuild the DB.
> 
> Eike Hein wrote:
>     I guess I'm not entirely sure how root replacing the file with root ownership and root making the file with root ownership aren't the same problem.
>     
>     Maybe it should check for SUDO_UID and always use that uid for the file ownership if set?
> 
> Martin Gräßlin wrote:
>     > Maybe it should check for SUDO_UID and always use that uid for the file ownership if set?
>     
>     wouldn't help if someone uses su instead of sudo, but for sudo users it sounds like a good idea

if they use su, $HOME isn't preserved anyway so it's not a problem


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123857/#review80819
-----------------------------------------------------------


On May 21, 2015, 11:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123857/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 11:36 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> 3 commits fixing; a crash, what caused the crash, and why we weren't auto recovering from it.
> 
> QFile::open() will return a Read/Write error on failed access,
> PermissionsError is only in the result of a setPermissions call.
> 
> CCBUG: 342438
> 
> If running as root, keep file ownership the same as the original file we're replacing.
> 
> $HOME is often preserved as root, making us write cache files in the
> user's home directory. 
> 
> CCBUG: 342438
> 
> Guard against being unable to open stream
> 
> This can happen if we are unable to open the database when a
> notifyDatabaseChanged signal is emitted.
> Other places guard also against this eventuality.
> 
> BUG: 342438
> 
> 
> Diffs
> -----
> 
>   src/kbuildsycoca/kbuildsycoca.cpp d14f1f950cdb0d8c9fefbce2a4740f211d3d97a1 
>   src/services/kservicegroupfactory.cpp 8cfc6c6670d3b87e8ed6bdfe4aeac947846afc18 
> 
> Diff: https://git.reviewboard.kde.org/r/123857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150526/04f90406/attachment.html>