Review Request 123890: Don't show "KDE Frameworks version" in the About KDE dialog

Kai Uwe Broulik kde at privat.broulik.de
Sun May 24 14:55:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123890/#review80775
-----------------------------------------------------------



src/kaboutkdedialog_p.cpp (line 46)
<https://git.reviewboard.kde.org/r/123890/#comment55377>

    I suppose you can also remove the HTML stuff since KTitleWidget now uses an increased font size anyway.


- Kai Uwe Broulik


On Mai 24, 2015, 4:26 vorm., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123890/
> -----------------------------------------------------------
> 
> (Updated Mai 24, 2015, 4:26 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Doesn't make sense, if you want to know which frameworks version you're using you can use the application dialog version, this is about kde, and as such it's about the community, the frameworks version there matters nothing
> 
> 
> Diffs
> -----
> 
>   src/kaboutkdedialog_p.cpp 1c3539b 
> 
> Diff: https://git.reviewboard.kde.org/r/123890/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150524/97cf2185/attachment.html>


More information about the Kde-frameworks-devel mailing list