Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

[Bhushan Shah]

> On May 21, 2015, 1:31 p.m., Milian Wolff wrote:
> > src/klocalizedstring.cpp, line 23
> > <https://git.reviewboard.kde.org/r/123867/diff/1/?file=370328#file370328line23>
> >
> >     shouldn't this be
> >     
> >         #include <cmath>

ah yeah.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123867/#review80680
-----------------------------------------------------------


On May 21, 2015, 11:20 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123867/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 11:20 a.m.)
> 
> 
> Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett Clark.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console
> 
> Follow up to,
> 
> commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
> Author: Milian Wolff <mail at milianw.de>
> Date:   Mon May 18 10:52:29 2015 +0200
> 
>     Fix compiler warning about potential truncation.
>     
>     klocalizedstring.cpp:1126:46: warning: absolute value function 'abs'
>     given an argument of type 'long' but has parameter of type 'int'
>     which may cause truncation of value
>     
>             kls.d->number = static_cast<pluraln>(abs(a));
>                                                  ^
>     klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead
> 
> 
> Diffs
> -----
> 
>   src/klocalizedstring.cpp 910f44d 
> 
> Diff: https://git.reviewboard.kde.org/r/123867/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150521/d9f5578b/attachment.html>