Review Request 123858: Fix memory leak in drags

[David Edmundson]

> On May 20, 2015, 12:59 p.m., David Edmundson wrote:
> > Turns out this isn't needed. It's a seemingly undocumented 'feature' the drag will be deleted by QDragManager::drag() when dropped
> > Sorry for the noise.

and by undocummneted, what I mean is; Clearly written in the documentation had I bothered to read it properly.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123858/#review80659
-----------------------------------------------------------


On May 20, 2015, 12:59 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123858/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 12:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> We don't need each QDrag object to have the entire lifespan of the mousearea. it makes every drag leak not only the qdrag object, but also the associated mimedata.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62ba9ddca12faea333d3336487fb47cc19b 
> 
> Diff: https://git.reviewboard.kde.org/r/123858/diff/
> 
> 
> Testing
> -------
> 
> Draged lots of items from kickoff to the panel.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150520/ad8fb321/attachment.html>