Review Request 123858: Fix memory leak in drags
Aleix Pol Gonzalez
aleixpol at kde.org
Wed May 20 00:38:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123858/#review80646
-----------------------------------------------------------
src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 312)
<https://git.reviewboard.kde.org/r/123858/#comment55296>
Makes sense, maybe it would be better to use deleteLater? In case it's used somewhere...
+1
- Aleix Pol Gonzalez
On May 20, 2015, 2:23 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123858/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 2:23 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> We don't need each QDrag object to have the entire lifespan of the mousearea. it makes every drag leak not only the qdrag object, but also the associated mimedata.
>
>
> Diffs
> -----
>
> src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62ba9ddca12faea333d3336487fb47cc19b
>
> Diff: https://git.reviewboard.kde.org/r/123858/diff/
>
>
> Testing
> -------
>
> Draged lots of items from kickoff to the panel.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150520/426d5a4a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list