Review Request 123595: Relax KUser test to allow for a "nogroup" group.

[Albert Astals Cid]

> On mai. 5, 2015, 9:08 p.m., Marko Käning wrote:
> > Looks like the test is still failing: 
> > 
> > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/
> > 
> > Anything I could do?
> 
> David Faure wrote:
>     Yes, you could try applying the patch :)
>     
>     This isn't committed yet, due to no "Ship It".
> 
> Scarlett Clark wrote:
>     CI patch test results: 
>     https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/36/console
>     
>     Still fails, but new failure.
> 
> Scarlett Clark wrote:
>     All green with updated patch!
>     https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/

Is build.kde.org not using the upstream code of git repos? That's dangerous, is there a way to know easily which builds are patched?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123595/#review79919
-----------------------------------------------------------


On mai. 19, 2015, 8:01 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123595/
> -----------------------------------------------------------
> 
> (Updated mai. 19, 2015, 8:01 a.m.)
> 
> 
> Review request for KDE Frameworks, Marko Käning and Scarlett Clark.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> http://pig.made-it.com/uidgid.html shows that we can't rely on
> what happens with an invalid id or group; on some systems they will
> belong to a "nogroup" group.
> 
> REVIEW: 123595
> 
> 
> Diffs
> -----
> 
>   autotests/kusertest.cpp d17a2d3e97d5056524281eb18766377e48a0da35 
> 
> Diff: https://git.reviewboard.kde.org/r/123595/diff/
> 
> 
> Testing
> -------
> 
> Still passes on Linux; should fix the CI for mac, AFAICS.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150519/7b3343bc/attachment.html>