Review Request 123838: Move from QDesktopWidget to QScreen

[Martin Klapetek]

> On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote:
> > src/notifybypopup.cpp, line 298
> > <https://git.reviewboard.kde.org/r/123838/diff/1/?file=369884#file369884line298>
> >
> >     I fear that's now most likely no longer the same. I assume that QDesktopWidget::availableGeometry() is the combination of all screens, while QScreen::availableGeometry() is for one screen.
> 
> Aleix Pol Gonzalez wrote:
>     Yes, now it will put it properly in the center-top of the primary screen instead of all workspaces.
> 
> Martin Klapetek wrote:
>     Yup, exactly. However I'm thinking about actually changing it to bottom-left by default, just like normal notifications do. There's really little to no reason why it should be center-top (especially since it's notification fallback).

Positioning the popups bottom-right is not as straight forward as it may seem and will require much more time spent on this. But as I have other pending stuff, this will have to wait for now.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123838/#review80591
-----------------------------------------------------------


On May 19, 2015, 12:40 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123838/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 12:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> As summary
> 
> 
> Diffs
> -----
> 
>   src/kpassivepopup.cpp a3a927b 
>   src/notifybypopup.cpp 8975121 
> 
> Diff: https://git.reviewboard.kde.org/r/123838/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150519/3b0995ad/attachment.html>