Review Request 123838: Move from QDesktopWidget to QScreen

Aleix Pol Gonzalez aleixpol at kde.org
Mon May 18 16:55:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123838/#review80588
-----------------------------------------------------------



src/notifybypopup.cpp (line 292)
<https://git.reviewboard.kde.org/r/123838/#comment55251>

    It's QGuiApplication, in fact. Can be worth changing.


Would it make sense to also do it in kpassivepopup.cpp as well?

- Aleix Pol Gonzalez


On May 18, 2015, 6:38 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123838/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 6:38 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> As summary
> 
> 
> Diffs
> -----
> 
>   src/notifybypopup.cpp 8975121d546fbaa0c3f4d930b4d65f765905d313 
> 
> Diff: https://git.reviewboard.kde.org/r/123838/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150518/c10ae966/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list