Review Request 123794: Implement "find previous" in KTextEdit.

Jeremy Whiting jpwhiting at kde.org
Thu May 14 22:08:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123794/#review80365
-----------------------------------------------------------

Ship it!


Nice! cache the options, switch direction, findNext, then unswitch directions. Looks good.

- Jeremy Whiting


On May 14, 2015, 3:59 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123794/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 3:59 p.m.)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: ktextwidgets
> 
> 
> Description
> -------
> 
> Implement "find previous" in KTextEdit.
> 
> 
> Diffs
> -----
> 
>   src/widgets/ktextedit.h 17d446ac2cb1f08adb298fd1f02d09429352b32e 
>   src/widgets/ktextedit.cpp 6bc22064efee68934afd0988bebedc5cce7e0488 
> 
> Diff: https://git.reviewboard.kde.org/r/123794/diff/
> 
> 
> Testing
> -------
> 
> Ctrl+F and F3/shift+F3 in ktextedittest.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150514/c6a92e0b/attachment.html>


More information about the Kde-frameworks-devel mailing list