Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

[Jeremy Whiting]

> On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 8
> > <https://git.reviewboard.kde.org/r/123742/diff/3/?file=368712#file368712line8>
> >
> >     I insist, feature_sumary goes at the bottom. (and is already there) Is it needed to have it twice?

Yes, otherwise we only get the generic cmake failure. Actually, let me check... Maybe it only means we get a bunch of failures for the include calls in addition to the verbose ECM message.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80299
-----------------------------------------------------------


On May 13, 2015, 7 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123742/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 7 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Make ECM missing message explain a) what ECM is, and b) where to find it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 
> 
> Diff: https://git.reviewboard.kde.org/r/123742/diff/
> 
> 
> Testing
> -------
> 
> KNewStuff (and any other framework we add these changes to) now reports the ECM url and name when it isn't found at cmake time.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150513/fef5f88c/attachment-0001.html>