Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

[Kevin Funk]

> On May 13, 2015, 6:45 a.m., Kevin Funk wrote:
> > I'd reorder the code:
> > 
> > ```
> > ...
> > 
> > include(FeatureSummary)
> > 
> > find_package(ECM ...)
> > set_target_properties(ECM ...)
> > feature_summary(...)
> > 
> > ...
> > ```
> > 
> > I know that it is a bit harder to script this way , but helps code readability :D

Just to say, +1 from me. Better error reporting is always helpful.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80275
-----------------------------------------------------------


On May 13, 2015, 12:28 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123742/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 12:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Make ECM missing message explain a) what ECM is, and b) where to find it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 
> 
> Diff: https://git.reviewboard.kde.org/r/123742/diff/
> 
> 
> Testing
> -------
> 
> KNewStuff (and any other framework we add these changes to) now reports the ECM url and name when it isn't found at cmake time.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150513/feaf2848/attachment.html>