Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

Aleix Pol Gonzalez aleixpol at kde.org
Wed May 13 01:41:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80270
-----------------------------------------------------------


+1

I'd like to know other people's opinion on this, as this should end up on most frameworks.
Personally I'm unsure that showing the url will enlighten people, but it's better that than the terribly verbose and useless cmake errors.

- Aleix Pol Gonzalez


On May 13, 2015, 2:28 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123742/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 2:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Make ECM missing message explain a) what ECM is, and b) where to find it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 
> 
> Diff: https://git.reviewboard.kde.org/r/123742/diff/
> 
> 
> Testing
> -------
> 
> KNewStuff (and any other framework we add these changes to) now reports the ECM url and name when it isn't found at cmake time.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150513/45f42185/attachment.html>


More information about the Kde-frameworks-devel mailing list