Review Request 123735: version of QmlObject with a static engine

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80252
-----------------------------------------------------------



src/kdeclarative/qmlobjectsharedengine.h (line 57)
<https://git.reviewboard.kde.org/r/123735/#comment55048>

    std::unique_ptr<...> ...
    then you can also forget about the delete in the destructor.



src/kdeclarative/qmlobjectsharedengine.cpp (line 48)
<https://git.reviewboard.kde.org/r/123735/#comment55050>

    static const QQmlEngine ...
    
    Prevents changing the pointer later on.



src/kdeclarative/qmlobjectsharedengine.cpp (line 75)
<https://git.reviewboard.kde.org/r/123735/#comment55049>

    remove if you decide to use a smart pointer for this one.


- Mark Gaiser


On mei 12, 2015, 4:12 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123735/
> -----------------------------------------------------------
> 
> (Updated mei 12, 2015, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/CMakeLists.txt d73bff0 
>   src/kdeclarative/kdeclarative.cpp b3906e2 
>   src/kdeclarative/qmlobject.h f26b67d 
>   src/kdeclarative/qmlobject.cpp c483665 
>   src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION 
>   src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150512/6816ffc1/attachment.html>