Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.
Aleix Pol Gonzalez
aleixpol at kde.org
Mon May 11 22:58:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123724/#review80228
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 11, 2015, 6:55 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123724/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 6:55 p.m.)
>
>
> Review request for KDE Frameworks and KDEPIM.
>
>
> Repository: kpeople
>
>
> Description
> -------
>
> Hardcoding files like this seems like a bad idea.
>
>
> Diffs
> -----
>
> autotests/persondatatests.h 30eeeb5cd647c713f1b438543a54516ced9f3ede
> autotests/persondatatests.cpp 73098d3717509ad80761bbd02000b4ce5060bbb2
> autotests/personsmodeltest.h 5b8879521f334459c4f73c2708b3368c543e40a3
> autotests/personsmodeltest.cpp b19d1baf8a2c2e617d4b6128df29fbab3b8e61a7
>
> Diff: https://git.reviewboard.kde.org/r/123724/diff/
>
>
> Testing
> -------
>
> Tests still pass.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150511/298a94bc/attachment.html>
More information about the Kde-frameworks-devel
mailing list